mksurfdata_esmf: Refactor mksoiltex #2737
Conversation
samsrabin
added
code health
samsrabin
added
the
priority: low
|
Output surface dataset at 1.9x2.5 resolution as of 9a2759f is bit-for-bit identical with version from ctsm5.2.027. However, my implementation of |
samsrabin
added
the
PR status: awaiting review
|
@samsrabin I think it's ok to remove "option 2" at this point. There's record of it if we ever decide to resuscitate it. Also, is this PR affected by the latest updates that occurred here? |
|
Thankfully no, this touches a different part of the code. |
samsrabin
removed
the
PR status: awaiting review
samsrabin
added
test: mksurfdata
samsrabin
removed
the
priority: low
There was a problem hiding this comment.
@samsrabin thanks again for this refactor. I like what you've done and thanks for keeping the comments indicating, for example, what -4 means and so on.
I think I looked this over previously and didn't formally review/approve it at the time. Based on our earlier conversations here, I see that you have a few unchecked checkboxes, but I'm happy to approve preemptively.
| end if | ||
| if (sand_o(no,1) < 0._r4) then | ||
| if (int(sand_o(no,1)) == -4) then | ||
| sand_o(no,:) = 99._r4 |
There was a problem hiding this comment.
@samsrabin I haven't looked at this in a long while, but judging from sand_o + clay_o = 100 when these two start equal to -4, I will agree with your assessment that the flag -4 indicates sand dunes regardless of which variable we look at.
Description of changes
Refactors
mksoiltex()subroutine to make it easier to understand and avoid duplicated code.Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed (include github issue #): None
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
Outputs are bit-for-bit identical with previous version (disabled organic_o option 2)Removing that codeOther remaining tasks
is_neg_4to be more meaningful. I think it indicates sand dunes, but is that really true for ALL variables or justPCT_SAND?TODO: Remove as unnecessary?be removed?